[csharp-netcore] Fix handling of Dictionary query parameters and fix deepObject style parameter handling #8848
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was triggered by this issue which it should close #8798
Looking into the issue I found that indeed SwaggerUI and the csharp-netcore client libraries were generating different queries. Neither of which was getting read by the newly updated aspnetcore generator (#8826). It appears that neither format was acceptable there and this is also something Swashbuckle needs to fix (domaindrivendev/Swashbuckle.AspNetCore#2034) as their generated spec does not actually work with the controller its supposed to query.
This pull request does two things:
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.1.x
,6.0.x
Closes #8798