Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Java (jersey2) ApiClient debug cannot be enabled #8756

Conversation

tomred-net
Copy link
Contributor

@tomred-net tomred-net commented Feb 19, 2021

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

To fix #8755

@tomred-net
Copy link
Contributor Author

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01)

Change to Java Jersey2 ApiClient mustache

@tomred-net
Copy link
Contributor Author

tomred-net commented Feb 19, 2021

Is this possible to be considered for 5.1.X ? I cannot find a branch with that name so I have targeted master.

@wing328
Copy link
Member

wing328 commented Feb 19, 2021

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328
Copy link
Member

wing328 commented Feb 19, 2021

Current master is for the upcoming 5.1.0 release.

@wing328
Copy link
Member

wing328 commented Feb 19, 2021

Please also run these to update the samples

./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh

so that the CI can test the change.

@tomred-net tomred-net force-pushed the fix-8755-java-jersey2-apiclient-debug-cannot-be-enabled branch from 9d4f10d to 8709e9a Compare February 22, 2021 00:10
@tomred-net
Copy link
Contributor Author

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

resolved - author updated

@tomred-net
Copy link
Contributor Author

Please also run these to update the samples

./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh

so that the CI can test the change.

rebased with master and updated samples

@tomred-net
Copy link
Contributor Author

Current master is for the upcoming 5.1.0 release.

Thank you for your help

@wing328
Copy link
Member

wing328 commented Mar 27, 2021

Sorry we missed it in the 5.1.0 release. We'll include it in the 5.1.1 release instead.

@wing328 wing328 merged commit 38b49e7 into OpenAPITools:master Mar 27, 2021
@wing328 wing328 changed the title fix #8755 [BUG] Java (jersey2) ApiClient debug cannot be enabled [BUG] Java (jersey2) ApiClient debug cannot be enabled Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Java (jersey2) ApiClient debug cannot be enabled
2 participants