Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GO] Add additional AWS v4 signature config options to go client generator #8706

Merged
merged 1 commit into from
Feb 21, 2021

Conversation

kpiotrowski
Copy link
Contributor

Golang client generator allows to include the AWS v4 signature. However, It's not possible to provide AWS session token (required when we use temporary credentials) and some configuration parameters like region and service name are hardcoded.

This PR adds additional configuration options: SessionToken, Region and Service to the existing sigv4 implementation.

This change maintain backward compatibility. Old, hardcoded values for region and service name are used as a default ones.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @jirikuncar (2021/01)

@kpiotrowski kpiotrowski changed the title Add additional AWS v4 signature parameters to go client generator [GO] Add additional AWS v4 signature config options to go client generator Feb 15, 2021
Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@wing328 wing328 merged commit a9e797c into OpenAPITools:master Feb 21, 2021
@wing328 wing328 added this to the 5.1.0 milestone Mar 16, 2021
@wing328
Copy link
Member

wing328 commented Mar 22, 2021

@kpiotrowski thanks for the PR, which has been included in the v5.1.0 release: https://twitter.com/oas_generator/status/1373636654024380423

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants