[OCaml] Fix enum returnType in of_json.mustache for Api Impl #8631
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cgensoul
Enum return types seem to be incorrectly handled in api implementations
*_api.ml
for json swagger.txt.For operations returning enums, processing of return values is rendered as
where
PushResult
is an enum. It should however render toThe cause seems to be that neither
isEnum
nordatatypeWithEnum
is available for operations inof_json.mustache
:This fix works for me, however I suppose that a solution could be substantially more elegant if I only was more with conversant CodeGen internals.
PR checklist