Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust client] upgrade reqwest crate to 0.11 #8603

Merged
merged 2 commits into from
Feb 12, 2021

Conversation

typester
Copy link
Contributor

@typester typester commented Feb 2, 2021

This p-r upgrades the reqwest crate to 0.11.

reqwest 0.11 uses tokio 1.0 and it should be totally preferable for most of tokio users.
Also, since 0.11 make multipart support optional, I added it to the features list.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@typester
Copy link
Contributor Author

typester commented Feb 2, 2021

@wing328
Copy link
Member

wing328 commented Feb 3, 2021

Thanks for the PR. I don't think it's a breaking change so I'll re-target the PR to master instead.

@wing328 wing328 changed the base branch from 5.1.x to master February 3, 2021 03:19
@wing328 wing328 added this to the 5.0.1 milestone Feb 3, 2021
@wing328 wing328 changed the base branch from master to 5.1.x February 3, 2021 03:25
@wing328
Copy link
Member

wing328 commented Feb 3, 2021

Looks like your PR is based on 5.1.x so I'll keep it that way to avoid merging those sample update (5.1.x) changes back in current master.

I'll merge this and cherry-pick the change into master instead.

@typester
Copy link
Contributor Author

typester commented Feb 3, 2021

@wing328 No, I would say that this p-r includes a breaking change.

reqwest 0.11 depends on tokio 1.0, while reqwest 0.10 and earlier depends on tokio 0.2.
And tokio 1.0 and 0.2 cannot be used at the same time unless you use a compatibility layer such as tokio_compat.

If the current user is in the tokio 0.2 codebase, it would be less confusing to continue to use reqwest 0.10 for this library as well.

That's why I did this p-r for 5.1.x.

@wing328
Copy link
Member

wing328 commented Feb 3, 2021

@typester thanks for the explanation. Let's keep this targeting 5.1.x

@wing328 wing328 modified the milestones: 5.0.1, 5.1.0 Feb 8, 2021
@wing328 wing328 changed the base branch from 5.1.x to master February 8, 2021 13:20
@wing328
Copy link
Member

wing328 commented Feb 12, 2021

@wing328 wing328 merged commit ec39a2f into OpenAPITools:master Feb 12, 2021
@wing328
Copy link
Member

wing328 commented Mar 22, 2021

@typester thanks for the PR, which has been included in the v5.1.0 release: https://twitter.com/oas_generator/status/1373636654024380423

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants