-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rust client] upgrade reqwest crate to 0.11 #8603
[rust client] upgrade reqwest crate to 0.11 #8603
Conversation
Thanks for the PR. I don't think it's a breaking change so I'll re-target the PR to master instead. |
Looks like your PR is based on 5.1.x so I'll keep it that way to avoid merging those sample update (5.1.x) changes back in current master. I'll merge this and cherry-pick the change into master instead. |
@wing328 No, I would say that this p-r includes a breaking change.
If the current user is in the That's why I did this p-r for 5.1.x. |
@typester thanks for the explanation. Let's keep this targeting 5.1.x |
Travis tests passed via https://travis-ci.org/github/OpenAPITools/openapi-generator/builds/758662988 |
@typester thanks for the PR, which has been included in the v5.1.0 release: https://twitter.com/oas_generator/status/1373636654024380423 |
This p-r upgrades the reqwest crate to 0.11.
reqwest 0.11 uses tokio 1.0 and it should be totally preferable for most of tokio users.
Also, since 0.11 make multipart support optional, I added it to the features list.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.1.x
,6.0.x