-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated import for kotlin Parcelize annotation #8590
Conversation
Hey @kalinjul thanks for your contribution 👍 Could you please also apply the new Parcelize plugin in the gradle file
And also run this commands please.
Thanks 😊 |
I added the plugin (although the android-kotlin-extensions, which was required before, wasn't included before) and generated the samples. |
Yes, you are right, it was probably forgotten. |
I'm sorry I couldn't find the code that uses gradle 5.1.1 for building the samples. Obviously, this has to be replaced by a newer version, too. |
CI failed, I think it's not related to this PR. |
Restarted the failed jobs. Let's see how that goes. |
I don't know about the current travis failure, but shippable reports:
As I had to update the kotlin gradle plugin, this error was introduced by the changes in this PR. I just don't know how to fix it, because I can't find a reference to gradle 5.2.1 anywhere in the source. It obviously has to be updated to a newer gradle version as well. |
I also can't find the problem 🙁 |
From Shippable log:
Looks like we need to install a newer version of Gradle (e.g. 5.3 or newer) to fix the build failure? |
TravisCI failure already fixed in the master. |
@kalinjul I have been fighting the CI, and to make it pass, can you please revert the kotlin and gradle versions? Thanks |
CircleCI failure already fixed in the master. |
It this change reverted @wing328? Because when i apply parcelizeModels: "true" kotlin-parcelize plugin isn't being used |
Can you try the latest stable release v5.1.0 or latest master and create a new issue for tracking if it's still the case? |
Yes it works with 5.1.0. |
This replaces the import kotlinx.android.parcel.parcelize with kotlinx.parcel.Parcelize, as the former is deprecated as of kotlin 1.4.20 (and will be removed with the next version or something)
Also see https://youtrack.jetbrains.com/issue/KT-40030.
This would also resolve issue #8073.
I'm also required to mention the technical committee for kotlin:
@jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.1.x
,6.0.x