-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java native][dotnetcore] Implement QueryParameter deepObject style #8563
[java native][dotnetcore] Implement QueryParameter deepObject style #8563
Conversation
…or client generators java native and dotnetcore.
The Shippable build fails with:
Can you please assist? |
cc @OpenAPITools/generator-core-team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally an didn't spot any issue
@@ -0,0 +1,66 @@ | |||
/* | |||
* Copyright 2018 OpenAPI-Generator Contributors (https://openapi-generator.tech) | |||
* Copyright 2018 SmartBear Software |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will remove this line in one of my upcoming PRs
@@ -0,0 +1,64 @@ | |||
/* | |||
* Copyright 2018 OpenAPI-Generator Contributors (https://openapi-generator.tech) | |||
* Copyright 2018 SmartBear Software |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will remove this line in one of my upcoming PRs
[java native][dotnetcore] Implement QueryParameter deepObject style for client generators java native and dotnetcore.
#469
@mandrean (2017/08) @frankyjuang (2019/09) @shibayan (2020/02)
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01)
Please have a look at the new tests:
with the test document modules/openapi-generator/src/test/resources/3_0/deepobject.yaml
The urls for the deepObject query parameters are generated as specified in
https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.3.md#style-values
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.1.x
,6.0.x