Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java native][dotnetcore] Implement QueryParameter deepObject style #8563

Merged

Conversation

Reinhard-PTV
Copy link
Contributor

[java native][dotnetcore] Implement QueryParameter deepObject style for client generators java native and dotnetcore.

#469

@mandrean (2017/08) @frankyjuang (2019/09) @shibayan (2020/02)
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01)

Please have a look at the new tests:

  • modules/openapi-generator/src/test/java/org/openapitools/codegen/java/JavaClientDeepObjectTest.java
  • modules/openapi-generator/src/test/java/org/openapitools/codegen/csharpnetcore/CSharpNetCoreClientDeepObjectTest.java

with the test document modules/openapi-generator/src/test/resources/3_0/deepobject.yaml

The urls for the deepObject query parameters are generated as specified in

https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.3.md#style-values

PR checklist

  • [ x ] Read the contribution guidelines.
  • [ x ] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [ x ] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • [ x ] File the PR against the correct branch: master, 5.1.x, 6.0.x
  • [ x ] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

…or client generators java native and dotnetcore.
@Reinhard-PTV
Copy link
Contributor Author

The Shippable build fails with:

W: GPG error: http://binaries.erlang-solutions.com/debian xenial Release: The following signatures were invalid: BADSIG D208507CA14F4FCA Erlang Solutions Ltd. [email protected]
W: The repository 'http://binaries.erlang-solutions.com/debian xenial Release' is not signed.
W: An error occurred during the signature verification. The repository is not updated and the previous index files will be used. GPG error: https://downloads.apache.org/cassandra/debian 311x InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY E91335D77E3E87CB
W: Failed to fetch http://www.apache.org/dist/cassandra/debian/dists/311x/InRelease The following signatures couldn't be verified because the public key is not available: NO_PUBKEY E91335D77E3E87CB
E: Failed to fetch http://binaries.erlang-solutions.com/debian/dists/xenial/contrib/binary-amd64/Packages.bz2 Hash Sum mismatch

Can you please assist?

@wing328
Copy link
Member

wing328 commented Feb 3, 2021

cc @OpenAPITools/generator-core-team

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally an didn't spot any issue

@wing328 wing328 merged commit 1006d2f into OpenAPITools:master Feb 14, 2021
@@ -0,0 +1,66 @@
/*
* Copyright 2018 OpenAPI-Generator Contributors (https://openapi-generator.tech)
* Copyright 2018 SmartBear Software
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,64 @@
/*
* Copyright 2018 OpenAPI-Generator Contributors (https://openapi-generator.tech)
* Copyright 2018 SmartBear Software
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants