Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Qt5][C++] Fixed QByteArray::toUtf8 with FILE as request body. Included <stdexcept>. #8550

Merged
merged 4 commits into from
Jan 30, 2021
Merged

[Qt5][C++] Fixed QByteArray::toUtf8 with FILE as request body. Included <stdexcept>. #8550

merged 4 commits into from
Jan 30, 2021

Conversation

igor-sirotin
Copy link
Contributor

@igor-sirotin igor-sirotin commented Jan 27, 2021

  • Added '#include ' where std::runtime_error is used
    I get a build error with MSVC 16.6.30114.105 without this include:
error C2039: 'runtime_error': is not a member of 'std'
error C3861: 'runtime_error': identifier not found
  • Fixed QByteArray::toUtf8 with FILE as request body
    In api-body.mustache there's .toUtf8() call on QString output to get a valid QByteArray for the following input.request_body.append(const QByteArray&). This one is not needed when output is obtained already as QByteArray.

  • Updated related samples

  • Updated generator docs

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

ping @ravinikam (2017/07) @stkrwork (2017/07) @etherealjoy (2018/02) @MartinDelille (2018/03) @muttleyxd (2019/08)

* Added '#include <stdexcept>' where std::runtime_error is used
* Fixed request with FILE body: QByteArray doesn't have ::toUtf8()
* Updated related samples
@wing328
Copy link
Member

wing328 commented Jan 29, 2021

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@igor-sirotin
Copy link
Contributor Author

igor-sirotin commented Jan 29, 2021

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

@wing328, oops, my fault!
Added this e-mail to my GitHub account. Thanks for the tip.

@etherealjoy
Copy link
Contributor

@igor-sirotin
Changes looks good to me. Were you able to compile this also on Linux?

@igor-sirotin
Copy link
Contributor Author

igor-sirotin commented Jan 29, 2021

@etherealjoy, no, I haven't done that.
Totally relied on CI, because the changes aren't OS-dependent.

@wing328 wing328 merged commit 328cadb into OpenAPITools:master Jan 30, 2021
@igor-sirotin igor-sirotin deleted the bugfix/cpp-qt5 branch January 30, 2021 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants