-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Qt5][C++] Fixed QByteArray::toUtf8 with FILE as request body. Included <stdexcept>. #8550
Conversation
* Added '#include <stdexcept>' where std::runtime_error is used * Fixed request with FILE body: QByteArray doesn't have ::toUtf8() * Updated related samples
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
@wing328, oops, my fault! |
@igor-sirotin |
@etherealjoy, no, I haven't done that. |
I get a build error with MSVC 16.6.30114.105 without this include:
Fixed
QByteArray::toUtf8
with FILE as request bodyIn
api-body.mustache
there's.toUtf8()
call onQString output
to get a validQByteArray
for the followinginput.request_body.append(const QByteArray&)
. This one is not needed whenoutput
is obtained already asQByteArray
.Updated related samples
Updated generator docs
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.1.x
,6.0.x
ping @ravinikam (2017/07) @stkrwork (2017/07) @etherealjoy (2018/02) @MartinDelille (2018/03) @muttleyxd (2019/08)