-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[swift5] Fix request closure not being called #8537
[swift5] Fix request closure not being called #8537
Conversation
@4brunu Podfile.lock of a test app is conflicting. Should I revert it? Or what's the procedure? |
I think you can delete it, and run pod install again. |
Looks good to me 👍 |
Could you just run |
Done! Sorry, it was late yesterday :D @4brunu . |
Sure, take your time 🙂 |
@4brunu I don#t get the conflict, since in the latest master commit the directory |
Sorry for my confusion, you are right, the sample project in |
…entApp/" This reverts commit 5ad327c.
@wing328 this PR is ready to merge, the CI is failing, but it's not related to this PR. |
Fixes #8511
Self got deallocated due to
[weak self]
and no other strong references.Because of that, request closures wouldn't be called anymore.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.1.x
,6.0.x