Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[swift5] Fix request closure not being called #8537

Conversation

fl034
Copy link
Contributor

@fl034 fl034 commented Jan 25, 2021

Fixes #8511

Self got deallocated due to [weak self] and no other strong references.
Because of that, request closures wouldn't be called anymore.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@fl034
Copy link
Contributor Author

fl034 commented Jan 25, 2021

@4brunu Podfile.lock of a test app is conflicting. Should I revert it? Or what's the procedure?

@4brunu
Copy link
Contributor

4brunu commented Jan 25, 2021

I think you can delete it, and run pod install again.

@4brunu
Copy link
Contributor

4brunu commented Jan 26, 2021

Looks good to me 👍

@4brunu
Copy link
Contributor

4brunu commented Jan 26, 2021

Could you just run pod install on samples/client/test/swift5/default/TestClientApp/ to recreate the podfile.lock?

@fl034
Copy link
Contributor Author

fl034 commented Jan 26, 2021

Done! Sorry, it was late yesterday :D @4brunu .
But what's the procedure now for the merge conflict?

@4brunu
Copy link
Contributor

4brunu commented Jan 26, 2021

Sure, take your time 🙂
Could you fix the merge conflict with the master branch?

@fl034
Copy link
Contributor Author

fl034 commented Jan 26, 2021

@4brunu I don#t get the conflict, since in the latest master commit the directory samples/client/test is not existing. Therefore the file can't be conflicting, right?

@4brunu
Copy link
Contributor

4brunu commented Jan 26, 2021

Sorry for my confusion, you are right, the sample project in samples/client/test/swift5/default/TestClientApp was deleted.
Could you please delete the file?

@4brunu
Copy link
Contributor

4brunu commented Jan 26, 2021

@wing328 this PR is ready to merge, the CI is failing, but it's not related to this PR.

@wing328 wing328 added this to the 5.0.1 milestone Jan 26, 2021
@wing328 wing328 merged commit f6019f0 into OpenAPITools:master Jan 27, 2021
@fl034 fl034 deleted the swift5-fix-8511-request-closure-not-being-called branch January 27, 2021 18:20
@wing328 wing328 changed the title [swift5] Fix #8511 (request closure not being called) [swift5] Fix request closure not being called Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][swift5] Closure isn't called anymore in latest snapshot with default configuration
3 participants