Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gradle Plugin] Allow to set additional property of any type. Useful for Boolean values. #8507

Conversation

xsveda
Copy link
Contributor

@xsveda xsveda commented Jan 22, 2021

Gradle Plugin's additionalProperties are of type Map<String, String>. When a project tries to set a Boolean property it needs to put it as a String (i.e. "true") which is not evaluated as proper Boolean value by mustache template.

This PR update additionalProperties to Map<String, Any>.

Use case comes from moko-network library: icerockdev/moko-network#59

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Jan 25, 2021

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328
Copy link
Member

wing328 commented Jan 25, 2021

cc @OpenAPITools/generator-core-team

@xsveda xsveda force-pushed the fix_only_string_values_can_be_set_as_additional_properties_through_gradle_plugin branch from fcf859a to 7106673 Compare January 25, 2021 07:29
@wing328 wing328 added this to the 5.1.0 milestone Mar 6, 2021
Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit e25fa8e into OpenAPITools:master Mar 6, 2021
@xsveda xsveda deleted the fix_only_string_values_can_be_set_as_additional_properties_through_gradle_plugin branch March 6, 2021 21:12
@wing328
Copy link
Member

wing328 commented Mar 22, 2021

@xsveda thanks for the PR, which has been included in the v5.1.0 release: https://twitter.com/oas_generator/status/1373636654024380423

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants