Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][Client][Vertx] Use Vertx reference instead of static class in ApiImpl template #8501

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

ricardozanini
Copy link
Contributor

Fix #8492

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after reading more about vertx.getOrCreateContext vs Vertx.currentContext

@wing328 wing328 added this to the 5.0.1 milestone Jan 28, 2021
@wing328 wing328 changed the title [Java] [Client] [Vertx] Fix #8492 - Use Vertx reference instead of static class in ApiImpl template [Java][Client][Vertx] Use Vertx reference instead of static class in ApiImpl template Jan 28, 2021
@wing328 wing328 merged commit e377eab into OpenAPITools:master Jan 28, 2021
@ricardozanini ricardozanini deleted the issue-8492 branch January 28, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [Client] [Java] [Vertx] Current context may return NPE when creating new WebClient
2 participants