Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds hasValidation to all java core Schema classes #8474

Merged
merged 22 commits into from
Jan 21, 2021

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Jan 19, 2021

Ensures that getHasValidation values are correct for
CodegenModel
CodegenProperty
CodegenParameter
CodegenResponse
This is a feature break out for #7651

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@spacether spacether marked this pull request as draft January 19, 2021 20:52
@spacether spacether changed the title Adds has validation tests Adds hasValidation to all java core Schema classes Jan 20, 2021
@spacether spacether marked this pull request as ready for review January 21, 2021 03:49
@spacether spacether added Client: Java Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. Enhancement: Feature labels Jan 21, 2021
@spacether spacether added this to the 5.0.1 milestone Jan 21, 2021
@spacether spacether merged commit 2331432 into OpenAPITools:master Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. Enhancement: Feature Feature: Generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants