Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature][python-flask] Add CORS support to python-flask server #8472

Merged
merged 3 commits into from
Jan 29, 2021

Conversation

ceresek
Copy link
Contributor

@ceresek ceresek commented Jan 19, 2021

Adds basic CORS support to the server generated with the python-flask generator (and the derived python-aiohttp and python-blueplanet). Enabled with featureCORS option (same as similar option in other generators). Disabled by default.

Mentioning TC members for Python as instructed in the PR checklist: @taxpon @frol @mbohlool @cbornet @kenjones-cisco @tomplus @Jyhess @arun-nalla @spacether.

@spacether
Copy link
Contributor

spacether commented Jan 21, 2021

@ceresek thank you for your PR. The feature generally looks good but it broke tests in circle and travis. Can you get them passing?

@ceresek
Copy link
Contributor Author

ceresek commented Jan 22, 2021

@spacether Thank you for your comments. I fixed the Travis issue (forgot to update the samples and that was the check that failed), but I might need some advice with Circle. The parallel logs are a bit challenging to read, but the only serious failure I see is Maven failing to fetch a dependency from the Maven Central, with lots of "Connection reset" errors, and the same test builds and runs fine locally. What am I missing ?

@spacether
Copy link
Contributor

Thank you for your sample fix. It looks like circle balked when it tried to download a maven package. I just restarted it which may resolve it. Let's wait and see.

@wing328
Copy link
Member

wing328 commented Jan 29, 2021

All tests passed 👍

@wing328 wing328 merged commit 061552f into OpenAPITools:master Jan 29, 2021
@wing328 wing328 added this to the 5.0.1 milestone Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants