Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds isNull to codegenX java core classes that represent schemas #8462

Merged
merged 4 commits into from
Jan 17, 2021

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Jan 17, 2021

Adds isNull to codegenModel codegenParameter codegenProperty codegenResponse
This is different than nullable: True
isNull should be set to true for schemas of type null like:

  schema:
    type: 'null'

Note: this is a v3.1 feature
Adding this property and these getIsNull setIsNull methods is a feature break out for #7651

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@spacether spacether changed the title Adds isNull to codegenModel codegenParameter codegenProperty codegenResponse Adds isNull to codegenX java core classes that represent schemas Jan 17, 2021
@spacether
Copy link
Contributor Author

Closing and re opening for travis

@spacether spacether closed this Jan 17, 2021
@spacether spacether reopened this Jan 17, 2021
@spacether spacether added this to the 5.0.1 milestone Jan 17, 2021
@spacether spacether merged commit e9c850f into OpenAPITools:master Jan 17, 2021
@spacether spacether deleted the adds_isNull branch January 17, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants