Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JMeter] Support json data in csv #8461

Merged
merged 1 commit into from
Jan 25, 2021
Merged

[JMeter] Support json data in csv #8461

merged 1 commit into from
Jan 25, 2021

Conversation

kannkyo
Copy link
Contributor

@kannkyo kannkyo commented Jan 17, 2021

Fix #8460

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@@ -110,7 +110,7 @@
</elementProp>{{/queryParams}}{{#bodyParam}}
<elementProp name="{{paramName}}" elementType="HTTPArgument">
<boolProp name="HTTPArgument.always_encode">false</boolProp>
{{=<% %>=}}<stringProp name="Argument.value">${<% paramName %>}</stringProp><%={{ }}=%>
{{=<% %>=}}<stringProp name="Argument.value">${__javaScript("${<% paramName %>}".replace(/'/g\, '"'),)}</stringProp><%={{ }}=%>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kannkyo thanks for the fix. I think one limitation with such approach is that if the json data contains ', e.g.

{
  "name": "John O'Shea"
}

the result will not work as it will become:

{
  "name": "John O"Shea"
}

I'm happy to merge this fix while looking for better approach to address cases like the above.

@wing328 wing328 merged commit c7a7116 into OpenAPITools:master Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][JMeter] can't throw json data from csv
2 participants