Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Fixes file upload + download, adds tests #8437

Merged
merged 11 commits into from
Jan 15, 2021

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Jan 14, 2021

Adds python file upload and download tests
When landed, this will fix:

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run
    mvn clean package
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    to update all Petstore samples related to your fix.
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@spacether spacether marked this pull request as draft January 14, 2021 05:44
@spacether spacether changed the title Adds python file upload tests Adds python file upload + download tests Jan 14, 2021
@spacether spacether modified the milestone: 5.0.1 Jan 15, 2021
@spacether spacether changed the title Adds python file upload + download tests Fixes file upload + download, adds tests Jan 15, 2021
@spacether spacether added this to the 5.0.1 milestone Jan 15, 2021
@spacether spacether marked this pull request as ready for review January 15, 2021 19:35
@spacether spacether changed the title Fixes file upload + download, adds tests [python] Fixes file upload + download, adds tests Jan 15, 2021
@spacether spacether merged commit c4dbd2c into OpenAPITools:master Jan 15, 2021
@spacether spacether deleted the adds_python_file_upload_tests branch January 15, 2021 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant