Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PYTHON] use _Endoint to allow apis to have Endpoint #8405

Merged

Conversation

RonnyPfannschmidt
Copy link
Contributor

@RonnyPfannschmidt RonnyPfannschmidt commented Jan 11, 2021

Fixes #8404

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run
    mvn clean package
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    to update all Petstore samples related to your fix.
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

if a type was named Endpoint, its import for use in the api would shadow
the name Endpoint for the internal utility
@RonnyPfannschmidt RonnyPfannschmidt changed the title [PYTHON] fix #8404: use api_client package directly to avoid shadowin… [PYTHON] fix #8404: use_Endoint to allow apis to have Endpoint Jan 13, 2021
@RonnyPfannschmidt
Copy link
Contributor Author

copying the python tech team

@taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @tomplus (2018/10) @Jyhess (2019/01) @arun-nalla (2019/11) @spacether (2019/11)

i would strongly recommend to set this up as a subteam in the org instead of a list of individual names

@RonnyPfannschmidt RonnyPfannschmidt marked this pull request as ready for review January 13, 2021 09:38
@spacether spacether added this to the 5.0.1 milestone Jan 13, 2021
Copy link
Contributor

@spacether spacether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR. Looks good!

@spacether spacether merged commit 6b6d1b1 into OpenAPITools:master Jan 13, 2021
@wing328 wing328 changed the title [PYTHON] fix #8404: use_Endoint to allow apis to have Endpoint [PYTHON] fix use_Endoint to allow apis to have Endpoint Feb 3, 2021
@wing328 wing328 changed the title [PYTHON] fix use_Endoint to allow apis to have Endpoint [PYTHON] use _Endoint to allow apis to have Endpoint Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][Python] own Endpoint type shadows autogenerated Endpoint helper for python
3 participants