Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed basic authentication function in sttp client #8396

Merged
merged 4 commits into from
Jan 12, 2021
Merged

Renamed basic authentication function in sttp client #8396

merged 4 commits into from
Jan 12, 2021

Conversation

aneksamun
Copy link
Contributor

@aneksamun aneksamun commented Jan 9, 2021

Fixed #8395 replacing withCredentials with basic.
Please see more details in official sttp client documentation
https://sttp.softwaremill.com/en/latest/requests/authentication.html.
Thanks.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@clasnake @jimschubert @shijinkui @ramzimaalej @chameleon82 @Bouillie

@aneksamun
Copy link
Contributor Author

CircleCI build unrelated error:

[ERROR] Failed to execute goal on project petstore-okhttp-gson: Could not resolve dependencies for project org.openapitools:petstore-okhttp-gson:jar:1.0.0: Failed to collect dependencies at com.squareup.okhttp3:okhttp:jar:3.14.7: Failed to read artifact descriptor for com.squareup.okhttp3:okhttp:jar:3.14.7: Could not transfer artifact com.squareup.okhttp3:okhttp:pom:3.14.7 from/to central (https://repo.maven.apache.org/maven2): Connection reset -> [Help 1]

@wing328
Copy link
Member

wing328 commented Jan 10, 2021

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@aneksamun
Copy link
Contributor Author

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328 Thanks for pointing this out. I've done changes as requested.

@wing328 wing328 changed the title Fix #8395 - renamed basic authentication function in sttp client Renamed basic authentication function in sttp client Jan 12, 2021
@wing328 wing328 merged commit a80788d into OpenAPITools:master Jan 12, 2021
@aneksamun aneksamun deleted the fix_issue8395 branch January 12, 2021 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][scala-sttp] error generating client with basic authentication
2 participants