Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generated go client cannot upload file #8393

Merged
merged 2 commits into from
Feb 16, 2021
Merged

Fix generated go client cannot upload file #8393

merged 2 commits into from
Feb 16, 2021

Conversation

dhontecillas
Copy link
Contributor

Fixes #8392 with the naive approach of checking if the body type is **os.File , so it can read its content and avoid the bug of not reading the bytes and having content-length 0.

Tested the fixed code on a separate branch in the same repo used to reproduce the issue : https://github.com/dhontecillas/openapi-generator-go-upload-bug/tree/test_fix (the updated line can be found in https://github.com/dhontecillas/openapi-generator-go-upload-bug/blob/test_fix/pkg/bug/client.go#L415 ). When running the go run . command in that branch, the bug is not reproduced anymore. We get an output of :

The request failed for a different reason: Post "http://127.0.0.1:8000/upload": dial tcp 127.0.0.1:8000: connect: connection refused

That is the expected result as we do not have any server running.

Can you have a look @antihax @grokify @kemokemo @jirikuncar please ? thank you

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@dhontecillas
Copy link
Contributor Author

hi @jirikuncar , I see there is a test failing for this PR, could you help me into fixing that ?

@wing328
Copy link
Member

wing328 commented Jan 29, 2021

cc @antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @jirikuncar (2021/01)

@wing328 wing328 added this to the 5.1.0 milestone Feb 16, 2021
@wing328
Copy link
Member

wing328 commented Feb 16, 2021

CircleCI failure due to code format change in the sample. Will fix it after merging this in the master.

@wing328 wing328 changed the title Fix/8392 generated go client cannot upload file Fix generated go client cannot upload file Feb 16, 2021
@wing328 wing328 merged commit 51c8fd1 into OpenAPITools:master Feb 16, 2021
@wing328
Copy link
Member

wing328 commented Mar 22, 2021

@dhontecillas thanks for the PR, which has been included in the v5.1.0 release: https://twitter.com/oas_generator/status/1373636654024380423

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][Go] Generated go client cannot upload file
3 participants