Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C][Client] Fix the memory leak when a JSON of model fails to parse #8390

Merged
merged 1 commit into from
Jan 10, 2021

Conversation

ityuhui
Copy link
Contributor

@ityuhui ityuhui commented Jan 9, 2021

The function *_parseFromJSON()
e.g. pet_t *pet_parseFromJSON(cJSON *petJSON) creates and returns a model pet_t according to the parameter cJSON *petJSON.

If petJSON is not a valid cJSON for pet_t, the function pet_parseFromJSON can not create the model pet_t successfully, and return NULL directly. At this time, some parts of pet_t have been created, e.g. category_local_nonprim, but the function forgets to release its memory, this will cause memory leak.

This PR fixes this memory leak via deleting the memory before return NULL

This PR only covers the type of isModel/complexType for the member of model, does not cover other types e.g. isArray, isFreeFormObject, isMap because now I only have the use case of isModel/complexType. We can fix other types when we meet them in future.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328 @zhemant @michelealbano

@auto-labeler
Copy link

auto-labeler bot commented Jan 9, 2021

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@wing328 wing328 added this to the 5.0.1 milestone Jan 10, 2021
@wing328 wing328 merged commit 0284fcd into OpenAPITools:master Jan 10, 2021
@ityuhui ityuhui deleted the yh-fix-memleak-parse-json branch January 10, 2021 10:11
BulderKristian pushed a commit to BulderKristian/openapi-generator that referenced this pull request Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants