[C][Client] Fix the memory leak when a JSON of model fails to parse #8390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
*_parseFromJSON()
e.g.
pet_t *pet_parseFromJSON(cJSON *petJSON)
creates and returns a modelpet_t
according to the parametercJSON *petJSON
.If
petJSON
is not a valid cJSON forpet_t
, the functionpet_parseFromJSON
can not create the modelpet_t
successfully, andreturn NULL
directly. At this time, some parts ofpet_t
have been created, e.g.category_local_nonprim
, but the function forgets to release its memory, this will cause memory leak.This PR fixes this memory leak via deleting the memory before
return NULL
This PR only covers the type of
isModel/complexType
for the member of model, does not cover other types e.g.isArray, isFreeFormObject, isMap
because now I only have the use case ofisModel/complexType
. We can fix other types when we meet them in future.PR checklist
./bin/generate-samples.sh
to update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH.master
,5.1.x
,6.0.x
@wing328 @zhemant @michelealbano