[Slim] Update main documentation #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kotlin server README has been used as a ref. There are no links to apis and models docs, because Slim codegen doesn't provide them right now. Also I'm not sure about white spaces, but we can change it anytime in future.
wing328
approved these changes
Aug 21, 2018
wing328
reviewed
Aug 21, 2018
| @@ -1,12 +1,58 @@ | |||
| # OpenAPI generated server | |||
| # php-base - PHP Slim Server library for OpenAPI Petstore *_/ ' \" =end -- \\r\\n \\n \\r | |||
There was a problem hiding this comment.
We may want to update php-base (packageName) with a better default value in another PR.
There was a problem hiding this comment.
@wing328 Got any suggestion for default value?
There was a problem hiding this comment.
@ybelenko since it's used by both PHP client and server generators, what about naming the default as "openapi-package"?
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
* [Slim] Update main documentation Kotlin server README has been used as a ref. There are no links to apis and models docs, because Slim codegen doesn't provide them right now. Also I'm not sure about white spaces, but we can change it anytime in future. * [Slim] Refresh samples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.3.x,4.0.x. Default:master.Description of the PR
@wing328 suggested to use Kotlin readme as a ref. The only significant difference is that I've removed links to apis and models docs as soon as SlimCodegen doesn't provide them for now.
@jebentier @dkarlovi @mandrean @jfastnacht @ackintosh