Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To fix model selection using ":" as the separator #8388

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

GORA-SAG
Copy link
Contributor

@GORA-SAG GORA-SAG commented Jan 9, 2021

  1. unable to use --global-property models="User,Pet" as this creates only User model.
  2. to solve the issue, instead of "," separator used ":" separator
  3. made some changes with that
  4. need to refresh the documentation

To fix #7358

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

1. unable to use --global-property models="User,Pet" as this creates only User model.
2. to solve the issue, instead of "," separator used ":" separator
3. made some changes with that
@wing328 wing328 changed the title 7358 To fix model selection Jan 10, 2021
@wing328
Copy link
Member

wing328 commented Jan 10, 2021

cc @OpenAPITools/generator-core-team

@wing328
Copy link
Member

wing328 commented Jan 10, 2021

@GORA-SAG thanks for the fix. Can you please merge the latest master into your branch so as to fix the CI failures?

@GORA-SAG
Copy link
Contributor Author

@wing328 already my branch is merged with the master. Don't know why the CI integration is failing. Can you please have a look on the failure.

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and works for me. I'll update the doc in another PR.

@wing328
Copy link
Member

wing328 commented Jan 12, 2021

CI failure not related to this change

@wing328 wing328 merged commit ce3e0c7 into OpenAPITools:master Jan 12, 2021
@kuhnroyal
Copy link
Contributor

Hmm I tried exactly this but it didn't work. Not sure what I did wrong.

@GORA-SAG
Copy link
Contributor Author

Hi @kuhnroyal , what i did is just changed the separator as (:) for the models as you suggested and changed small thing in the code which is available in the commits.

@kuhnroyal
Copy link
Contributor

@GORA-SAG Yea I saw that and I tested it, I am just not sure why I didn't get it to work a couple days ago when I tried the same thing :)

@GORA-SAG
Copy link
Contributor Author

@kuhnroyal sometimes that will happen :)

@wing328 wing328 changed the title To fix model selection To fix model selection using ":" as the separator Feb 3, 2021
@wing328 wing328 changed the title To fix model selection using ":" as the separator To fix model selection using ":" as the separator Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use --global-property models="User,Pet" this creates only User model
3 participants