-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
To fix model selection using ":" as the separator #8388
Conversation
cc @OpenAPITools/generator-core-team |
@GORA-SAG thanks for the fix. Can you please merge the latest master into your branch so as to fix the CI failures? |
@wing328 already my branch is merged with the master. Don't know why the CI integration is failing. Can you please have a look on the failure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and works for me. I'll update the doc in another PR.
CI failure not related to this change |
Hmm I tried exactly this but it didn't work. Not sure what I did wrong. |
Hi @kuhnroyal , what i did is just changed the separator as (:) for the models as you suggested and changed small thing in the code which is available in the commits. |
@GORA-SAG Yea I saw that and I tested it, I am just not sure why I didn't get it to work a couple days ago when I tried the same thing :) |
@kuhnroyal sometimes that will happen :) |
To fix #7358
PR checklist
./bin/generate-samples.sh
to update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH.master
,5.1.x
,6.0.x