Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typescript-fetch: fix isCollectionFormatMulti for arrays of files #8376

Merged
merged 1 commit into from
Jan 8, 2021
Merged

Conversation

m1k1o
Copy link
Contributor

@m1k1o m1k1o commented Jan 7, 2021

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

Details

Similar problem as with typescript-axios in #8104, where isCollectionFormatMulti was not set properly for arrays with binary items.

Sample request body:

requestBody:
  content:
    multipart/form-data:
      schema:
        type: object
        properties:
          files:
            type: array
            items:
              type: string
              format: binary

Incorrect handling before PR:

        if (requestParameters.files) {
            formParams.append('files', requestParameters.files.join(runtime.COLLECTION_FORMATS["csv"]));
        }

Correct handling after PR:

        if (requestParameters.files) {
            requestParameters.files.forEach((element) => {
                formParams.append('files', element as any);
            })
        }

@macjohnny macjohnny changed the title fix isCollectionFormatMulti in TypeScript fetch typescript-fetch: fix isCollectionFormatMulti for arrays of files Jan 8, 2021
@macjohnny macjohnny added this to the 5.0.1 milestone Jan 8, 2021
@macjohnny macjohnny merged commit f2671fc into OpenAPITools:master Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants