[feature][dart] Add support for uniqueItems/sets #8375
Conversation
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
|
@agilob @josh-burton Please review if you find time |
| @@ -204,6 +204,44 @@ public void listPropertyTest() { | |||
| Assert.assertTrue(property2.isContainer); | |||
| } | |||
|
|
|||
| @Test(description = "convert a model with set property") | |||
|
LGTM, not sure whether other people maintaining jersey and typescript will be happy with changes in spec, but it looks like it works for their generator too. I probably should start using dart-dio, you're doing great work there mate. |
|
This is probably considered a breaking change without fallback? So it goes to 6.0.0? 😢 |
We did not consider adding set support is a breaking change in other generators (e.g. Ruby, Java, etc) before so I'm ok this change gets into the current master. |
|
@wing328 Sounds good to me, I have removed the draft label. Build failures seem unrelated as far as I can tell. |
|
Since there are changes to the test spec, can you please run |
|
I did, thats what caused the changes in TS/Kotlin. I can rebase and do that again, maybe something has changed in the meantime. |
|
Can you merge the latest master into your branch and update the samples again? I just did that and saw some changes to the Ruby and C# samples. |
* copy `uniqueItems` usage from 2.0 fake spec to `3.0` * add support for sets in parameters, responses and properties
kuhnroyal
force-pushed
the
dart/set-support
branch
from
15ae78c
to
dcfe117
Compare
|
Rebased and regenerated. |
uniqueItemsusage from 2.0 fake spec to 3.0PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.master,5.1.x,6.0.x