Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kotlin-Spring] Fix properties default value #8373

Merged
merged 3 commits into from
Jan 24, 2021

Conversation

cbornet
Copy link
Member

@cbornet cbornet commented Jan 7, 2021

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@jimschubert (2017/09) heart, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03)

@wing328 wing328 added this to the 5.0.1 milestone Jan 24, 2021
Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit 06ad7a5 into OpenAPITools:master Jan 24, 2021
@cbornet cbornet deleted the kotlin-spring-default branch January 24, 2021 23:31
@sticreations
Copy link

Hi, Sadly this introduced a new Bug when generating default Enum Values.

The name of the generated Enum is for example "TemperatureZone", the generated Code for the default value is
**` @field:JsonProperty("temperature_zone") var temperatureZone: OutboundZone.TemperatureZone? = TemperatureZoneEnum.NONE
**

The default value seems to get the classname wrong.

@sigand
Copy link
Contributor

sigand commented Jun 9, 2021

It seems to also so something to default values for strings. Generated code does not compile
@field:JsonProperty("exampleProperty") val exampleProperty: kotlin.String? = "example",

@sigand
Copy link
Contributor

sigand commented Jun 30, 2021

Having played around in the code, neither bug above is due to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants