Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dart][dart-dio] Generate the correct serializers #8357

Merged
merged 1 commit into from
Jan 7, 2021

Conversation

kuhnroyal
Copy link
Contributor

  • only generate actually used serializers (anything used in body or response)
  • generate previously missing serializers for collection types
  • improve formatting

Fixes #8270

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

CC @swipesight (2018/09) @jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12)

* only generate actually used serializers (anything used in body or response)
* generate previously missing serializers for collection types
* improve formatting
@auto-labeler
Copy link

auto-labeler bot commented Jan 6, 2021

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@@ -289,6 +289,7 @@ public void postProcessModelProperty(CodegenModel model, CodegenProperty propert
Map<String, Object> operations = (Map<String, Object>) objs.get("operations");
List<CodegenOperation> operationList = (List<CodegenOperation>) operations.get("operation");

Set<Map<String, Object>> serializers = new HashSet<>();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure this needs to be a set of maps? why not something simpler to debug like a list of tuples?

Copy link
Contributor Author

@kuhnroyal kuhnroyal Jan 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what mustache supports here, I assume with pairs you would somehow have to access .first .second in the templates, never seen this. I just followed the same way that is used everywhere else.

@wing328 wing328 added this to the 5.0.1 milestone Jan 7, 2021
@wing328 wing328 merged commit c432347 into OpenAPITools:master Jan 7, 2021
@kuhnroyal kuhnroyal deleted the dart-dio/fix-serializers branch January 7, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug][dart-dio] Allow models to be serialized within a map using MapBuilder
4 participants