[goserver] Fix single inheritance code generation for goserver #8356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The continuos integration appears to be failing for a docker pull issue that apepars to me to be unrelated with the pull request. |
|
@wing328 I see you are reviewing pull request. I think this one is relevant for generating correct code. |
|
@randomswdev sorry for taking so long to review your PR. Tested locally and didn't spot any issue. Thanks again for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is intended to fix an issue introduced with #4934.
The line
supportsInheritance = truehas been included in the cosntructor ofAbstractGoCodegen, which is also the parent class of the go server code generator. The pull request implements changes in the go client's and go deprecated'smodel.mustache, but not in the go server, even if the change inAbstractGoCodegenaffects also this generator.This PR addresses this.
@antihax @grokify @kemokemo @bkabrda
@wing328 possibly this should be included also in
5.1.x.