Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] fix generation for JavaTimeFormatter #8348

Merged

Conversation

borsch
Copy link
Member

@borsch borsch commented Jan 6, 2021

Fix for issue: #7952

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@borsch borsch force-pushed the fix-generation-of-javatimeformatter branch from 42fcec5 to 3de917c Compare January 8, 2021 08:30
@borsch borsch force-pushed the fix-generation-of-javatimeformatter branch from 6671e41 to 03d31bf Compare January 8, 2021 09:14
@borsch
Copy link
Member Author

borsch commented Jan 8, 2021

please review

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01)

@borsch borsch closed this Jan 19, 2021
@borsch borsch reopened this Jan 19, 2021
@borsch borsch closed this Jan 20, 2021
@borsch borsch reopened this Jan 20, 2021
@borsch borsch requested a review from wing328 January 22, 2021 11:03
Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and the result is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants