Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Allow using lists as globalProperty in config files #8339

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

kuhnroyal
Copy link
Contributor

@kuhnroyal kuhnroyal commented Jan 5, 2021

This allows for config files of this sort:

globalProperties:
  skipFormModel: true
  apiTests: false
  modelTests: false
  supportingFiles: ''
  models:
    - Pet
    - Dog
    - User
  apis:
    - UserApi

This is much easier to use than comma separated strings, especially for large lists (I have 50+ models out of 100+)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@kuhnroyal
Copy link
Contributor Author

@wing328 @GORA-SAG Do you guys think this is useful? I am using this for a while now in my projects with lots of classes and it really makes it a lot easier to configure.

@GORA-SAG
Copy link
Contributor

@kuhnroyal this is really cool and easy to configure and helpful in cases which involves more classes. typically in that situation providing it in a config file is more easy as we can't provide everything in command line, but for automation kind of stuff which involves some dynamic model changes then the fix that i have done will be helpful. ultimately it's depends on the use case.

@wing328
Copy link
Member

wing328 commented Jan 12, 2021

@kuhnroyal looks good 👍

To be clear, it's the config file supplied via -c (not a separate config file), right?

@kuhnroyal
Copy link
Contributor Author

@wing328 Yes, the existing config file that gets passed to the CLI with -c. Where should this be documented?

@wing328
Copy link
Member

wing328 commented Jan 22, 2021

cc @OpenAPITools/generator-core-team

@wing328
Copy link
Member

wing328 commented Mar 29, 2021

@kuhnroyal let's go with what you suggest in this PR 👍

@wing328 wing328 merged commit 6c8bc1e into OpenAPITools:master Mar 29, 2021
@wing328 wing328 added this to the 5.1.1 milestone Mar 29, 2021
@kuhnroyal kuhnroyal deleted the core/configuration branch April 1, 2021 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants