Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stackoverflow in toExampleValue() for python client #8326

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

fbl100
Copy link
Contributor

@fbl100 fbl100 commented Jan 4, 2021

Added a Set in toExampleValueRecursive() to keep track of which models we have
generated to avoid an infinite recursion for recursive models. An example of a recursive
model would be a GeoJson GeometryCollection.

@spacether This is a retry of the prior PR that was reverted due to an OS line ending issue.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

Added a Set<String> in toExampleValueRecursive() to keep track of which models we have
generated to avoid an infinite recursion for recursive models.  An example of a recursive
model would be a GeoJson GeometryCollection.
@spacether
Copy link
Contributor

spacether commented Jan 4, 2021

Thanks for the new PR! What code did you change to fix the line end issue?
Because there is only one commit I can't tell. Is it:
expectedValue = expectedValue.replaceAll("\\r\\n", "\n");?

@fbl100
Copy link
Contributor Author

fbl100 commented Jan 4, 2021

@spacether Yes, that was it. Sorry, I try to rebase/squash on my side (habit at my day job).

@spacether
Copy link
Contributor

Closing and re-opening to try to kick off travis

@spacether spacether closed this Jan 5, 2021
@spacether spacether reopened this Jan 5, 2021
@spacether spacether added this to the 5.0.1 milestone Jan 5, 2021
Copy link
Contributor

@spacether spacether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your new PR with the fix!
Merging here and keeping an eye on CI tests...

@spacether spacether linked an issue Jan 5, 2021 that may be closed by this pull request
6 tasks
@spacether spacether merged commit 04dfff8 into OpenAPITools:master Jan 5, 2021
@wing328 wing328 changed the title Fixes issue 8052: Stackoverflow in toExampleValue() for python client Stackoverflow in toExampleValue() for python client Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Stackoverflow in toExampleValue()
2 participants