Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new crystal client generator (beta) #8304

Merged
merged 28 commits into from
Jan 7, 2021
Merged

Add a new crystal client generator (beta) #8304

merged 28 commits into from
Jan 7, 2021

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Jan 2, 2021

  • create the first version (beta) of the crystal client generator.
  • test in travis CI with add_pet and get_pet_by_id

(still a lot to enhance/fix, will open an issue for tracking)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328 wing328 merged commit 1df7198 into master Jan 7, 2021
@wing328 wing328 deleted the crystal branch January 7, 2021 09:10
@cvgaviao
Copy link

I think you missed its unit tests. at least I was not able to find it when I pulled this change.

@wing328
Copy link
Member Author

wing328 commented Jan 12, 2021

@cvgaviao right, I've not yet added the unit tests (java class).

I've only added the integration tests (https://github.com/OpenAPITools/openapi-generator/blob/master/samples/client/petstore/crystal/spec/api/pet_api_spec.cr#L79) to start with.

Welcome PRs to add the unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants