Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Swift 5] fix Multipart FormData encoding and add support for Form URLEncoded enconding #8275

Merged
merged 14 commits into from
Jan 5, 2021

Conversation

4brunu
Copy link
Contributor

@4brunu 4brunu commented Dec 27, 2020

Previously it was only possible to use the encoding multipart/form-data when sending files.
With this PR that is fixed.

And it also adds support for 'application/x-www-form-urlencoded' fixing #8169

This PR also contains some fixes on code formatting.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11)

@4brunu 4brunu closed this Dec 27, 2020
@4brunu 4brunu reopened this Dec 27, 2020
@4brunu 4brunu changed the title [Swift 5] improve support for FormData encoding without files [Swift 5] improve support for Multipart FormData encoding without files Dec 28, 2020
@4brunu 4brunu changed the title [Swift 5] improve support for Multipart FormData encoding without files [Swift 5] improve support for Multipart FormData encoding without files and add support for form URLEncoded requests Dec 31, 2020
# Conflicts:
#	modules/openapi-generator/src/main/resources/swift5/libraries/alamofire/AlamofireImplementations.mustache
#	samples/client/petstore/swift5/alamofireLibrary/PetstoreClient/Classes/OpenAPIs/AlamofireImplementations.swift
@4brunu 4brunu changed the title [Swift 5] improve support for Multipart FormData encoding without files and add support for form URLEncoded requests [Swift 5] fix Multipart FormData encoding and add support for Form URLEncoded enconding Dec 31, 2020
# Conflicts:
#	modules/openapi-generator/src/main/resources/swift5/libraries/alamofire/AlamofireImplementations.mustache
#	samples/client/petstore/swift5/alamofireLibrary/PetstoreClient/Classes/OpenAPIs/AlamofireImplementations.swift
@4brunu 4brunu closed this Jan 4, 2021
@4brunu 4brunu reopened this Jan 4, 2021
# Conflicts:
#	modules/openapi-generator/src/main/resources/swift5/APIs.mustache
@4brunu
Copy link
Contributor Author

4brunu commented Jan 4, 2021

CI is failing, but I think it's not related to this PR.

$ echo "$DOCKER_HUB_PASSWORD" | docker login --username=$DOCKER_HUB_USERNAME --password-stdin;
Must provide --username with --password-stdin
The command "echo "$DOCKER_HUB_PASSWORD" | docker login --username=$DOCKER_HUB_USERNAME --password-stdin;" failed and exited with 1 during .

Your build has been stopped.

@wing328
Copy link
Member

wing328 commented Jan 5, 2021

Agreed it's not related.

@wing328 wing328 merged commit dd9a19a into OpenAPITools:master Jan 5, 2021
@4brunu 4brunu deleted the feature/swift5-enconding branch February 8, 2021 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants