-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Swift 5] fix Multipart FormData encoding and add support for Form URLEncoded enconding #8275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4brunu
changed the title
[Swift 5] improve support for FormData encoding without files
[Swift 5] improve support for Multipart FormData encoding without files
Dec 28, 2020
4brunu
changed the title
[Swift 5] improve support for Multipart FormData encoding without files
[Swift 5] improve support for Multipart FormData encoding without files and add support for form URLEncoded requests
Dec 31, 2020
# Conflicts: # modules/openapi-generator/src/main/resources/swift5/libraries/alamofire/AlamofireImplementations.mustache # samples/client/petstore/swift5/alamofireLibrary/PetstoreClient/Classes/OpenAPIs/AlamofireImplementations.swift
4brunu
changed the title
[Swift 5] improve support for Multipart FormData encoding without files and add support for form URLEncoded requests
[Swift 5] fix Multipart FormData encoding and add support for Form URLEncoded enconding
Dec 31, 2020
# Conflicts: # modules/openapi-generator/src/main/resources/swift5/libraries/alamofire/AlamofireImplementations.mustache # samples/client/petstore/swift5/alamofireLibrary/PetstoreClient/Classes/OpenAPIs/AlamofireImplementations.swift
wing328
reviewed
Jan 4, 2021
modules/openapi-generator/src/main/resources/swift5/APIs.mustache
Outdated
Show resolved
Hide resolved
# Conflicts: # modules/openapi-generator/src/main/resources/swift5/APIs.mustache
CI is failing, but I think it's not related to this PR.
|
Agreed it's not related. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was only possible to use the encoding
multipart/form-data
when sending files.With this PR that is fixed.
And it also adds support for 'application/x-www-form-urlencoded' fixing #8169
This PR also contains some fixes on code formatting.
PR checklist
./bin/generate-samples.sh
to update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH.master
,5.1.x
,6.0.x
@jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11)