[dart][dart-dio] Enable strong-mode and strict types #8231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agilob
reviewed
Dec 18, 2020
| @@ -43,15 +43,15 @@ class {{classname}} { | |||
| {{#queryParams}} | |||
| queryParams[r'{{baseName}}'] = {{paramName}}; | |||
| {{/queryParams}} | |||
| queryParams.removeWhere((key, value) => value == null); | |||
| headerParams.removeWhere((key, value) => value == null); | |||
| queryParams.removeWhere((key, dynamic value) => value == null); | |||
There was a problem hiding this comment.
if you put dynamic before value then for consistency we should have String before key
There was a problem hiding this comment.
Due to implicit-dynamic: false, you always have to be explicit about dynamic. But the String key is inferred.
agilob
approved these changes
Dec 18, 2020
9 tasks
7 tasks
Grohden
reviewed
Dec 20, 2020
| strict-raw-types: true | ||
| strong-mode: | ||
| implicit-dynamic: false |
There was a problem hiding this comment.
i see that there's no implicit-casts:false in this one, maybe thats the difference between mine and your usage?
There was a problem hiding this comment.
You are right, I just commented on your PR.
Grohden
approved these changes
Dec 20, 2020
kuhnroyal
force-pushed
the
dart-dio/strong-mode
branch
from
abb83be
to
3bc36df
Compare
|
I have updated this with |
This will make it easier to eventually transition to NNBD. Also fix some formatting things.
* raise minimum Dart version to 2.6 (to support spread collection) * add header to all files for language version * fix some missing imports that can be fixed (some remain due to missing inheritance support)
kuhnroyal
force-pushed
the
dart-dio/strong-mode
branch
from
3bc36df
to
0bc0268
Compare
|
Travis CI not related to this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The strict typing will make it easier to eventually transition to NNBD and prevents potential type errors.
Also fix some formatting things.
The same needs to be done for normal dart.
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.masterCC @swipesight (2018/09) @jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12)