Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go] Add constructor and IsValid method to enum types #8224

Merged
merged 2 commits into from
Apr 4, 2021

Conversation

zippolyte
Copy link
Contributor

@zippolyte zippolyte commented Dec 17, 2020

Add constructor and IsValid method to enum types.
This allows users of library to make they have valid value when not using the constants directly

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@zippolyte zippolyte changed the title Add constructor and IsValid method to enum types [go] Add constructor and IsValid method to enum types Dec 17, 2020
@zippolyte
Copy link
Contributor Author

cc @antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @bkabrda (2019/07)

@zippolyte
Copy link
Contributor Author

Friendly bump here 🙂

@zippolyte
Copy link
Contributor Author

cc @wing328

@wing328 wing328 added this to the 5.1.1 milestone Apr 4, 2021
@wing328 wing328 merged commit f8202df into OpenAPITools:master Apr 4, 2021
@wing328
Copy link
Member

wing328 commented Apr 4, 2021

@zippolyte sorry for taking a bit long. I've merged the PR. Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants