Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix csharp-netcore enum var name underscore and space handling #8213

Merged

Conversation

sbergen
Copy link
Contributor

@sbergen sbergen commented Dec 16, 2020

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

Fixes #8212

It seems I do not have the required permissions to perform the last step in the checklist.

@wing328
Copy link
Member

wing328 commented Dec 18, 2020

cc @mandrean (2017/08) @frankyjuang (2019/09) @shibayan (2020/02)

@sbergen
Copy link
Contributor Author

sbergen commented Dec 18, 2020

@wing328 Thanks for adding those mentions! I found the instructions a bit unclear here, as I'm used to using the Reviewers feature for requesting review, and assumed that was the expected method also here. Perhaps something like this could be clearer?

If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Jan 4, 2021

| If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Looks good to me. I wonder if you can submit a PR to revise the wording when you've time.

@wing328 wing328 added this to the 5.0.1 milestone Jan 4, 2021
@wing328
Copy link
Member

wing328 commented Jan 4, 2021

@sbergen thanks for the fix and the adding the tests.

@wing328 wing328 merged commit ee2f0e0 into OpenAPITools:master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][chsarp-netcore] Underscores and spaces aren't handled properly in enum var names
2 participants