Make frequently used IO resources autoclosable #8181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm the Kotlin changes also break my PR :( |
|
Yea, something untested got merged to master, dont worry about it. |
agilob
force-pushed
the
auto-closable-IO-resources
branch
from
58b2f4b
to
9d1c3ad
Compare
|
cc @OpenAPITools/generator-core-team |
|
The kotlin samples have been updated in the master. Please merge the latest master into this branch when you've time. |
…to auto-closable-IO-resources
|
@wing328 done! |
…to auto-closable-IO-resources
…to auto-closable-IO-resources
…to auto-closable-IO-resources
…to auto-closable-IO-resources
5 tasks
|
@OpenAPITools/generator-core-team @wing328 |
|
@wing328 @jimschubert any plans to merge it? |
|
Let me try to review over the weekend. |
wing328
approved these changes
Jan 11, 2021
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to reduce memory use and unlock them for use by operating system resource scheduler/allocator
Below you can see I run the same template manager test which opens and reads IO resources. I added extra line on debugger just to keep resources busy a bit longer for lsof to scan though them, this allows me to compare before/after results of my changes, as it would be much more difficult to automate this test inside maven, it's all manual.
List of files open by Linux checked with
Before changes:
Same test after changes:
Also reduced complexity of reading dart specific keywords from external file.
Autoclose input reader from ruby error stream
I do not know what the kotlin changes are, I promise ¯_(ツ)_/¯
Closes #1909 and fixes a few other unreported