-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JAVA][Rest-assured] add more informations about operations #815
Conversation
…eContextConsumer in ApiClient
@bbdouglas (2017/07) @JFCote (2017/08) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) |
Can you explain the use-case behind adding the swagger annotations? |
Hello, @jmini The main idea is to have ability to get constants from API specification inside client. Constants such as tages, notes, summary etc. Initially I've made it via public static final constants, but it wasn't convenient to be honest: a lot of constants. So the second solution was adding Context class which combines constants (tags etc.). See PR. But to my mind it was complicating of client. If you have any idea how I can improve or make it easy it will be very helpfull. |
Thank you for the clarification. It is a little sad to use a We can improve this in the future. I hope you did understood correctly the reasoning behind my question: I think it is important to have some context behind changes made with a PR. I took the liberty to update the PR description and the title. |
Follow up PR: #822 |
…ols#815) Add swagger annotations to client and set default baseReqSpec and baseContextConsumer in ApiClient
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.master
,3.3.x
,4.0.x
. Default:master
.Description of the PR
See also the description bellow: https://github.com/OpenAPITools/openapi-generator/pull/#issuecomment-413194142
A first version of this PR (using a context class) can be found here: #751