Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto-generated readme for cpprestsdk client #814

Merged
merged 3 commits into from
Aug 15, 2018
Merged

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Aug 14, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.3.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

  • Add auto-generated readme for cpprestsdk client
  • add pom.xml to run cmake, make to facilitate testing of the cpprestsdk petstore client

@wing328
Copy link
Member Author

wing328 commented Aug 14, 2018

cc @ravinikam (2017/07) @stkrwork (2017/07) @fvarose (2017/11) @etherealjoy (2018/02) @MartinDelille (2018/03)

{{/infoUrl}}

- API namespace: {{{apiPackage}}}
- Mdoel namespace: {{{modelPackage}}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Model

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed via b4defe2

### Build

```sh
cmake -DCPPREST_ROOT=/usr -DCMAKE_CXX_FLAGS="-I/usr/local/opt/openssl/include" -DCMAKE_MODULE_LINKER_FLAGS="-L/usr/local/opt/openssl/lib"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/usr/include/cpprest ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goal was to skip the error message about not setting CPPREST_ROOT. In b4defe2, I've removed the check instead.

<configuration>
<executable>cmake</executable>
<arguments>
<argument>-DCPPREST_ROOT=/usr</argument>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you install cpprest in /usr ?

Copy link
Contributor

@etherealjoy etherealjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is still not compilable out of the box due to the nature of the CMakeLists.txt for most users. But I think it can be improved in the future

@wing328
Copy link
Member Author

wing328 commented Aug 15, 2018

It is still not compilable out of the box due to the nature of the CMakeLists.txt for most users. But I think it can be improved in the future

Totally agree. It's a starting point. We'll keep improving it over time.

@wing328 wing328 merged commit 6de0968 into master Aug 15, 2018
@wing328 wing328 deleted the cpprest_macos branch August 16, 2018 10:10
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
* add auto-generated readme for cpprestsdk client

* update cpprest client sample

* remove error message from cmake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants