-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JAXRS-spec] Add option useSwaggerAnnotations (for MicroProfile-OpenAPI) #813
[JAXRS-spec] Add option useSwaggerAnnotations (for MicroProfile-OpenAPI) #813
Conversation
…in generated code. By default annotations are generated.
…(..) is too early
# Conflicts: # modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/JavaJAXRSSpecServerCodegen.java
Thank you for this PR. I like your approach.
The Shippable CI Job ensure that the content of the
|
I just ran |
I once generated this table: https://github.com/OpenAPITools/openapi-generator/wiki/Samples-folder#scripts (might be outdated) I have computed the list for your by looking at the Shippable error report. If you have time (takes some minutes), you can also run |
Thank you a lot for this contribution |
@michbeck100 thanks for the enhancement, which is included in the v3.2.2 stable release: https://twitter.com/oas_generator/status/1032252335131512832 |
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.master
,3.3.x
,4.0.x
. Default:master
.Description of the PR
The Microprofile OpenAPI specification allows to have just a static openapi.yaml file in the application module’s root
META-INF
folder (see here). So this PR adds an additional property "useSwaggerAnnotations" that doesn't generate the Swagger annotations if set to false (default value is true for backward compatibility).This way you can easily generate code that conforms to contract first and is compliant with the microprofile openapi specification