Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go] fix unused err in the Go code #8069

Closed
wants to merge 1 commit into from
Closed

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Dec 2, 2020

To fix #7961

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

cc @antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @bkabrda (2019/07)

@wing328 wing328 added this to the 5.0.0 milestone Dec 2, 2020
@wing328 wing328 marked this pull request as draft December 2, 2020 15:16
@wing328 wing328 modified the milestones: 5.0.0, 5.0.1 Dec 21, 2020
@wing328 wing328 modified the milestones: 5.0.1, 5.1.0 Feb 8, 2021
@wing328 wing328 modified the milestones: 5.1.0, 5.1.1 Mar 19, 2021
@wing328
Copy link
Member Author

wing328 commented Jan 17, 2022

Closed via #11178

@wing328 wing328 closed this Jan 17, 2022
@wing328 wing328 deleted the go-onoef-discriminator-err branch January 17, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][Go] UnmarshalJson has unused variable err if spec has oneOf without discriminator
1 participant