Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multi consumes in inline schema #789

Merged
merged 3 commits into from
Aug 15, 2018

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Aug 11, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

For https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/java/org/openapitools/codegen/InlineModelResolver.java#L71

Also uncomment and fixes some tests (20%) in InlineModelResolverTest.java

@wing328 wing328 modified the milestones: 3.2.1, 3.2.2 Aug 14, 2018
@wing328
Copy link
Member Author

wing328 commented Aug 15, 2018

@jimschubert thanks for the review. PR merged into master.

@wing328 wing328 merged commit ca651be into master Aug 15, 2018
@wing328 wing328 deleted the improve_inline_schema branch August 16, 2018 10:10
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
* add support for multi consumes in inline schema

* add copyright

* revert redirectTestOutputToFile change in pom.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants