Set swagger-parser to version 2.0.4 #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we need to put this PR on hold until swagger-api/swagger-parser#799 is solved. |
|
@jmini 👌 thanks for looking into that. |
|
This is "ON HOLD", we will move to |
4 tasks
jmini
changed the title
|
When Swagger Parser |
jmini
force-pushed
the
change_swagger-parser_version
branch
from
9f74c51
to
bf3ff65
Compare
jmini
changed the title
|
2.0.4 was released. This PR use it in OpenAPI-Generator |
wing328
approved these changes
Sep 6, 2018
There was a problem hiding this comment.
LGTM.
Swagger Parser 2.0.3 release has issues and that's why we skip it: https://github.com/swagger-api/swagger-parser/releases/tag/v2.0.3
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,4.0.x. Default:master.Description of the PR
With #696 swagger-parser was updated to a custom version.
This PR set it to the official
2.0.2version (see swagger-api/swagger-parser#780)