-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set swagger-parser to version 2.0.4 #787
Conversation
I think we need to put this PR on hold until swagger-api/swagger-parser#799 is solved. |
@jmini 👌 thanks for looking into that. |
This is "ON HOLD", we will move to |
When Swagger Parser |
9f74c51
to
bf3ff65
Compare
2.0.4 was released. This PR use it in OpenAPI-Generator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Swagger Parser 2.0.3 release has issues and that's why we skip it: https://github.com/swagger-api/swagger-parser/releases/tag/v2.0.3
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.master
,4.0.x
. Default:master
.Description of the PR
With #696 swagger-parser was updated to a custom version.
This PR set it to the official
2.0.2
version (see swagger-api/swagger-parser#780)