Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JAXRS-CXF] Improve handling of additional properties in JavaCXFClien… #7866

Conversation

cowclaw
Copy link
Contributor

@cowclaw cowclaw commented Nov 3, 2020

This PR improves the handling of additional properties of the JavaCXFClientCodegen and the corresponding tests.

Currently, when using the jaxrs-cxf-client generator without explicitly setting useGzipFeatureForTests and useLoggingFeatureForTests a warning is logged for each of these properties, saying: The value (generator's option) must be either boolean or string. Default to false. The behavior is fixed in this MR.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

cc: @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @bkabrda

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR.

@wing328 wing328 merged commit 2f30960 into OpenAPITools:master Nov 4, 2020
@wing328 wing328 added this to the 5.0.0 milestone Nov 4, 2020
@cowclaw cowclaw deleted the jaxrs_cxf_improve_additional_properties_handling branch November 4, 2020 06:16
@cowclaw
Copy link
Contributor Author

cowclaw commented Nov 4, 2020

LGTM. Thanks for the PR.

Thanks for the very fast review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants