Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add executionId to filehash #7848

Merged

Conversation

Zomzog
Copy link
Contributor

@Zomzog Zomzog commented Oct 30, 2020

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@Zomzog Zomzog force-pushed the 7820_maven_skipIfSpecIsUnchanged branch from ff3029e to 672ab85 Compare January 20, 2021 17:37
@Zomzog Zomzog marked this pull request as ready for review January 31, 2021 15:04
@Zomzog Zomzog force-pushed the 7820_maven_skipIfSpecIsUnchanged branch from 672ab85 to 9e9ee12 Compare January 31, 2021 15:10
@Zomzog Zomzog force-pushed the 7820_maven_skipIfSpecIsUnchanged branch from 9e9ee12 to a7a6d95 Compare January 31, 2021 17:30
@Zomzog
Copy link
Contributor Author

Zomzog commented Feb 4, 2021

Ping of core team, because it's a change in the maven plugin.
@wing328 (2015/07)
@jimschubert (2016/05)
@cbornet (2016/05)
@ackintosh (2018/02)
@jmini (2018/04) heart
@etherealjoy (2019/06)
@spacether (2020/05)

@Zomzog
Copy link
Contributor Author

Zomzog commented Feb 10, 2021

Hello,
Any chance this one can be review/merged?

@wing328
Copy link
Member

wing328 commented Mar 6, 2021

@Zomzog can you elaborate the problem it tries to resolve? Is it a breaking change?

@Zomzog
Copy link
Contributor Author

Zomzog commented Mar 13, 2021

@wing328 it fixes the #7820 issue.
I don't think it's a breaking change.

@wing328
Copy link
Member

wing328 commented Apr 5, 2021

@Zomzog thanks for the information. Let's get this in and ask the user to try it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants