Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust-server] Update templating docs to correct the name of x-response-id #7839

Merged
merged 1 commit into from
Apr 5, 2021
Merged

[rust-server] Update templating docs to correct the name of x-response-id #7839

merged 1 commit into from
Apr 5, 2021

Conversation

mattdowdell
Copy link
Contributor

I spotted a way to control the enum variants in rust-server for the responses in the docs, tried it out and discovered it doesn't work. Further digging found that the property was simply mislabelled in the docs and works as expected when using the correct property name.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@auto-labeler
Copy link

auto-labeler bot commented Oct 29, 2020

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@wing328
Copy link
Member

wing328 commented Apr 5, 2021

FYI. @richardwhiuk

@wing328
Copy link
Member

wing328 commented Apr 5, 2021

@mattdowdell thanks for the PR. Confirmed it's x-response-id in the code (java class)

@wing328 wing328 merged commit 226a8b5 into OpenAPITools:master Apr 5, 2021
@wing328 wing328 added this to the 5.1.1 milestone Apr 5, 2021
@mattdowdell mattdowdell deleted the rust-server/x-response-id branch April 5, 2021 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants