Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C][Client]Fix coredump in multi-thread environment #7835

Merged
merged 1 commit into from
Oct 30, 2020

Conversation

ityuhui
Copy link
Contributor

@ityuhui ityuhui commented Oct 29, 2020

@wing328 @zhemant @michelealbano

Described in libcurl official document https://curl.haxx.se/libcurl/c/libcurl.html, the functions curl_global_init and curl_global_cleanup cannot be called in multiple thread environment, or it will cause a coredump.

Following by the guide, this PR removes the 2 function calls from apiClient_create* and apiClient_free, and adds 2 new functions for user to call:

/*
 * In single thread program, the function apiClient_setupGlobalEnv is not needed.
 * But in multi-thread program, apiClient_setupGlobalEnv must be called before any worker thread is created
 */
void apiClient_setupGlobalEnv()
{
    curl_global_init(CURL_GLOBAL_ALL);
}

/*
 * This function apiClient_unsetupGlobalEnv must be called whether single or multiple program.
 * In multi-thread program, it is must be called after all worker threads end.
 */
void apiClient_unsetupGlobalEnv()
{
    curl_global_cleanup();
}

Then user can create more than one api clients with multiple threads safely.

The difference compared with the original use case in single thread environment is:
User needs call the function apiClient_unsetupGlobalEnv at the end of program.

The detail discussion can be found at the issue: kubernetes-client/c#34

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@auto-labeler
Copy link

auto-labeler bot commented Oct 29, 2020

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@wing328 wing328 added this to the 5.0.0 milestone Oct 29, 2020
@wing328 wing328 merged commit 8f06876 into OpenAPITools:master Oct 30, 2020
@ityuhui ityuhui deleted the yh-multi-thread-support branch October 30, 2020 10:42
@ityuhui
Copy link
Contributor Author

ityuhui commented Oct 30, 2020

Thanks @wing328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants