[C][Client]Fix coredump in multi-thread environment #7835
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@wing328 @zhemant @michelealbano
Described in libcurl official document https://curl.haxx.se/libcurl/c/libcurl.html, the functions
curl_global_init
andcurl_global_cleanup
cannot be called in multiple thread environment, or it will cause a coredump.Following by the guide, this PR removes the 2 function calls from
apiClient_create*
andapiClient_free
, and adds 2 new functions for user to call:Then user can create more than one api clients with multiple threads safely.
The difference compared with the original use case in single thread environment is:
User needs call the function
apiClient_unsetupGlobalEnv
at the end of program.The detail discussion can be found at the issue: kubernetes-client/c#34
PR checklist
./bin/generate-samples.sh
to update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH.master