Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[javascript-flowtyped] Fix Flow error #7786

Merged
merged 2 commits into from
Oct 26, 2020
Merged

Conversation

thSoft
Copy link
Contributor

@thSoft thSoft commented Oct 21, 2020

Fixes #7382 by fixing the deletion of the search field in localVarUrlObj.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@thSoft
Copy link
Contributor Author

thSoft commented Oct 21, 2020

@CodeNinjai @frol @cliffano Please review.

@wing328
Copy link
Member

wing328 commented Oct 26, 2020

@thSoft thanks for the PR, which looks good to me.

@wing328 wing328 added this to the 5.0.0 milestone Oct 26, 2020
@wing328 wing328 changed the title [javascript-flowtyped] Fix Flow error (#7382) [javascript-flowtyped] Fix Flow error Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][javascript-flowtyped] Flow check error (node.js)
2 participants