Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds additionalProperties to core schema classes #7761

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Oct 19, 2020

Adds additional properties to core schema classes
This is a feature break out for additionalProperties for #7613

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

Core Team:
@wing328 (2015/07) ❤️
@jimschubert (2016/05) ❤️
@cbornet (2016/05)
@ackintosh (2018/02) ❤️
@jmini (2018/04) ❤️
@etherealjoy (2019/06)
@spacether (2020/05)

@spacether spacether marked this pull request as draft October 19, 2020 21:56
@spacether spacether marked this pull request as ready for review October 20, 2020 16:02
@spacether spacether changed the title Adds additional properties to core schema classes Adds additionalProperties to core schema classes Oct 20, 2020
@spacether spacether added this to the 5.0.0 milestone Oct 20, 2020
@spacether spacether merged commit 28e92f9 into OpenAPITools:master Oct 20, 2020
@spacether spacether deleted the adds_additional_properties_to_core_schema_classes branch October 20, 2020 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant