[cpp-pistache] removed model namespace when unused for operations #775
Conversation
| @@ -250,7 +250,7 @@ public CodegenOperation fromOperation(String path, String httpMethod, Operation | |||
| if(importMapping.containsKey(hdr)) { | |||
| continue; | |||
| } | |||
| additionalProperties.put("hasModelImport", true); | |||
| operations.put("hasModelImport", true); | |||
There was a problem hiding this comment.
wouldnt it better to put this in the vendor extensions?
There was a problem hiding this comment.
We may consider adding this to the top level so that all generators can also use hasModelImport (I've seen another related request before)
There was a problem hiding this comment.
@etherealjoy please go with vendor extension for the time being (e.g. x-codegen-pistache-hasModelImport)
This reverts commit 13f0a8b.
|
@wing328 @stkrwork private Map<String, Object> processOperations(CodegenConfig config, String tag, \
List<CodegenOperation> ops, List<Object> allModels)is a if (imports.size() > 0) {
operations.put("hasImport", true);
}So I think it makes sense to add |
|
@etherealjoy thanks for the detailed explanation. I'm ok with your suggested change. We'll consider adding this to the default codegen later. |
…ons level instead of operation/vendorExtensions level.
…enAPITools#775) * Remove using model namespace when model is unused * Add comments to clarify introduction of hasModelImport at API/operations level instead of operation/vendorExtensions level.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,4.0.x. Default:master.Description of the PR
When there is no import of any model header remove the usage of model namespace as well for each model.
No impact to samples after generation.
Fixes #637 fully.
@ravinikam @MartinDelille @stkrwork @fvarose