Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT][TYPESCRIPT-ANGULAR] Add configurationPrefix option #7731

Conversation

sorohan
Copy link
Contributor

@sorohan sorohan commented Oct 16, 2020

Allow the Configuration (and ConfigurationParameters) APIs to be created unique by specifying a configurationPrefix.

This resolves #4101.

@sorohan
Copy link
Contributor Author

sorohan commented Oct 16, 2020

@macjohnny I'd appreciate your feedback on this one. It's the missing half of #7498

I think it will conflict with the other PR I have open, but obviously I can rebase it after that one is merged.

Copy link
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macjohnny macjohnny added this to the 5.0.0 milestone Oct 16, 2020
@macjohnny macjohnny merged commit cc5e0fe into OpenAPITools:master Oct 16, 2020
@sorohan sorohan deleted the feature/typescript-angular-configuration-prefix branch October 16, 2020 14:25
jimschubert added a commit that referenced this pull request Oct 17, 2020
* master: (66 commits)
  [Typescript][Angular] Fix generated README when using apiModulePrefix (#7725)
  remove outdated scala files (#7723)
  [FEAT][TYPESCRIPT-ANGULAR] Add configurationPrefix option to allow generating unique configuration token (#7731)
  [bug] Fix FILES sort and path provider issue (#7729)
  better csharp tests (#7727)
  [go] Improve examples generation (#7576)
  Fixes #7635: typescript-inversify generator wrongly handles array type parameters (#7636)
  [Java] Fix import mapping for arrays with reference items of type string (#7182)
  [Java][Native] Support oneOf/anyOf schemas (#7263)
  [BUG][Ada] Incorrect client Ada code generated (#7719)
  add cake, sbt integration (#7713)
  Use 3.0 spec in documentations, update docs  (#7710)
  remove github.com/antihax/optional from go.sum (#7692)
  Update junit to newer version (4.13.1) (#7690)
  [Fix/Dart2] Resolve an exception with status 204 and no body. (#7647)
  [typescript-angular] pass array as a single JSON string to url query when queryParamObjectFormat=json (fix #7620) (#7649)
  Add back HttpSigningConfiguration.cs
  remove HTTPSigningConfiguration.cs
  add AnyType support to Swift generators (#7644)
  fix warning, remove trailing spaces (#7659)
  ...
@jcimoch
Copy link

jcimoch commented Nov 17, 2020

When it will be available in 5.x release?

@macjohnny
Copy link
Member

@jcimoch
Copy link

jcimoch commented Nov 17, 2020

@macjohnny you mean when all items will be finalized? won't be there any more beta release including this?

@macjohnny
Copy link
Member

@jcimoch a release is over-due. Also, not all items need to be completed. According to the release schedule there should be a another beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ][typescript-angular] Option to rename ApiModule and Configuration
3 participants